[PATCH] D87777: [ASAN] Properly deal with musttail calls in ASAN

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 17:25:21 PDT 2020


wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

LGTM except a minor comment.



================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:562
+// point.
+static Instruction *adjustForMusttailCall(Instruction *I) {
+  ReturnInst *RI = dyn_cast<ReturnInst>(I);
----------------
Is there a better place for this helper and avoid duplication? We have a few copies of it now, TSAN, ASAN and EntryExitInstrumenter...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87777/new/

https://reviews.llvm.org/D87777



More information about the llvm-commits mailing list