[PATCH] D87708: [DAG] DAGTypeLegalizer::GenWidenVectorTruncStores - ensure correct extraction index (PR42046)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 16:21:30 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

> This is by inspection - as was mentioned on the ticket, this code isn't active at all in the tests and I've not been able to get it to fire

In theory, you just need the right kind of node.  That said, DAGCombiner specifically avoids bulding such a node, so not sure it ever happens in practice.  I think I'm okay with this as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87708/new/

https://reviews.llvm.org/D87708



More information about the llvm-commits mailing list