[PATCH] D87739: [WIP] scudo: Add an API for disabling memory initialization per-thread.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:417
+            // therefore it needs to be zeroed now.
+            memset(TaggedPtr, 0, Min(Size, PrevEnd - TaggedUserPtr));
+          } else if (Size) {
----------------
resizeTaggedChunk does not zero memory. I think this  memset needs to cover the entire allocation?


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:426
               computeOddEvenMaskForPointerMaybe(BlockUptr, BlockSize);
           TaggedPtr = prepareTaggedChunk(Ptr, Size, OddEvenMask, BlockEnd);
         }
----------------
Rename setRandomTag to setRandomTagAndZeroData ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87739/new/

https://reviews.llvm.org/D87739