[PATCH] D86657: Add new hidden option -print-crash-IR that prints out IR that caused opt pipeline to crash

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

some nits, but lgtm as long as yrouban approves



================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:22
 #include "llvm/IR/PassInstrumentation.h"
+#include "llvm/IR/PassManager.h"
 #include "llvm/IR/PassTimingInfo.h"
----------------
is this include necessary?


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:261-271
+// A pass for testing -print-on-crash.
+// DO NOT USE THIS EXCEPT FOR TESTING!
+class TriggerCrashPass : public PassInfoMixin<TriggerCrashPass> {
+public:
+  PreservedAnalyses run(Function &F, FunctionAnalysisManager &FAM);
+};
+
----------------
could you move this right after the noop passes below?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86657/new/

https://reviews.llvm.org/D86657