[PATCH] D87757: [SplitKit] Only copy live lanes

Wed Sep 16 12:45:36 PDT 2020

rampitec added a comment.

In D87757#2277557 <https://reviews.llvm.org/D87757#2277557>, @foad wrote:

> In D87757#2277232 <https://reviews.llvm.org/D87757#2277232>, @rampitec wrote:
>
>> In D87757#2276505 <https://reviews.llvm.org/D87757#2276505>, @foad wrote:
>>
>>> @rampitec this patch causes CodeGen/AMDGPU/splitkit-copy-bundle.mir to fail because it no longer generates any bundles. Could you help find a way to update the test case? I have pushed this patch to github in case you want to pull from there: https://github.com/jayfoad/llvm-project/tree/only-copy-live-lanes
>>
>> There is very high chance this test in unfixable with your changes as these prevent the very situation where the KIILs were formed. I'd say you may just generate checks there. At the end this code snippet did not compile and asserted, so we need to make sure it compiles. Bundles themselves are just an implementation detail.
>
> How about this? I dropped the ASM RUN line because it's awkward to use update_llc_test_checks and update_mir_test_checks in the same file.

Looks good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87757/new/

https://reviews.llvm.org/D87757