[PATCH] D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 12:19:58 PDT 2020


MaskRay added a comment.

In D87727#2277529 <https://reviews.llvm.org/D87727#2277529>, @rahmanl wrote:

> Sorry about the headache @MaskRay I should've built after rebasing.

No problem! There are 100 commits every day and a previous test can easily get stale after, say, 6 hours.
And for a revert (e.g. f80f2516a2697218eeb7af80de3b13c38f342987 <https://reviews.llvm.org/rGf80f2516a2697218eeb7af80de3b13c38f342987>), please mention the reason why it was reverted (it caused compilation issues. Even better it could have mentioned that it conflicted with a previous commit)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87727/new/

https://reviews.llvm.org/D87727



More information about the llvm-commits mailing list