[PATCH] D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 12:16:22 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:3
 
-# RUN: llvm-profdata show -sample %S/Inputs/compat-sample.profdata  | FileCheck %s 
+# RUN: llvm-profdata show -sample %S/Inputs/compat-sample.profdata  | FileCheck %s
 
----------------
`  |` -> ` |`


================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:10
+
+# RUN: llvm-profdata show -hot-func-list -sample %S/Inputs/compat-sample.profdata  | FileCheck %s -check-prefix=HOTFUNC
+# HOTFUNC: 24753993 out of 24754010 profile counts (100.00%) are from hot functions.
----------------
`  |` -> ` |`

(Nit: for FileCheck options, the two-dash `--check-prefix` is preferred.)


================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:18
+
+# OVERLAP: Program level:
+# OVERLAP-NEXT:   Whole program profile similarity: 100.000%
----------------
Indent this line so that the indentation difference with the next line matches the actual output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87740/new/

https://reviews.llvm.org/D87740



More information about the llvm-commits mailing list