[PATCH] D82678: [CGP] Set debug locations when optimizing phi types

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:5884-5886
       } else {
         return false;
       }
----------------
Orlando wrote:
> This is unrelated to your change (but is debug-info related), sorry for the extra noise...
> 
> It looks like we early-out of `optimizePhiType` here if `II` has a user which doesn't match the conditions above (i.e. not a phi, store, or bitcast).  Couldn't this cause a change in behaviour based on debug-info if `II` is used by a debug intrinsic (`isa<DbgVariableIntrinsic>(V)`)?
> 
Ah, ignore this, I was being silly. I somehow forgot that debug intrinsics wrap the values as metadata.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82678/new/

https://reviews.llvm.org/D82678