[PATCH] D86925: [MachineSink] add one more profitable pattern for sinking

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

> As expected, the improvement for the benchmark is gone now. : (

Too bad. Hopefully it would take long to come up with the follow up path.

The source change looks good to me (there's one lint report that needs fixing though: one of the comment is larger than 80-col), but we miss a test case.

Could you add a test case that capture specifically what this patch is doing?
In other words, a test case that runs the machine sink pass alone and that fails without that patch and passes with that patch.

You can produce the skeleton of the test by running `-stop-before machine-sink -simplify-mir`, then you can use that output as input of your test with `-run-pass=machine-sink`.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86925/new/

https://reviews.llvm.org/D86925