[PATCH] D87736: [PDB] Split TypeServerSource and extend CVIndexMap lifetime
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 16 10:18:19 PDT 2020
aganea added a comment.
I like a lot the change, it makes the API and the ownership more clear. But I am wondering: why not simply remove the `CVIndexMap` type? Do we need this extra indirection now? We could simply use a `TpiSource` API, instead of doing the `if (indexMap->isTypeServerMap)` in PDB.cpp? e.g. `class TpiSource { ... virtual ArrayRef<TypeIndex> indexMap()/typeMap(); }`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87736/new/
https://reviews.llvm.org/D87736
More information about the llvm-commits
mailing list