[PATCH] D86974: [IRSim] Adding basic implementation of llvm-sim.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/tools/llvm-sim/llvm-sim.cpp:133
+    for (BasicBlock &BB : F)
+      for (Instruction &I : BB)
+        LLVMInstNum.insert(std::make_pair(&I, InstructionNumber++));
----------------
If it's not necessary/desirable to number meta-instructions (e.g. debug info intrinsics), `BB.instructionsWithoutDebug()` might be a better fit here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86974/new/

https://reviews.llvm.org/D86974