[PATCH] D87762: [AMDGPU] Corrected directive to use for ELF weak refs

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp updated this revision to Diff 292225.
dp added a comment.

Added a test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87762/new/

https://reviews.llvm.org/D87762

Files:
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
  llvm/test/CodeGen/AMDGPU/hsa-globals.ll


Index: llvm/test/CodeGen/AMDGPU/hsa-globals.ll
===================================================================
--- llvm/test/CodeGen/AMDGPU/hsa-globals.ll
+++ llvm/test/CodeGen/AMDGPU/hsa-globals.ll
@@ -13,6 +13,8 @@
   ret void
 }
 
+ at weak_global = extern_weak addrspace(1) global i32
+
 ; ASM: .type linkonce_odr_global_program, at object
 ; ASM: .section .bss,#alloc,#write
 ; ASM: .weak linkonce_odr_global_program
@@ -48,3 +50,5 @@
 ; ASM: external_readonly:
 ; ASM: .long 0
 ; ASM: .size external_readonly, 4
+
+; ASM: .weak weak_global
Index: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
+++ llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp
@@ -40,7 +40,6 @@
   HasAggressiveSymbolFolding = true;
   COMMDirectiveAlignmentIsInBytes = false;
   HasNoDeadStrip = true;
-  WeakRefDirective = ".weakref\t";
   //===--- Dwarf Emission Directives -----------------------------------===//
   SupportsDebugInformation = true;
   DwarfRegNumForCFI = true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87762.292225.patch
Type: text/x-patch
Size: 1101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200916/04f4b66e/attachment.bin>