[PATCH] D87757: [SplitKit] Only copy live lanes

Wed Sep 16 06:24:49 PDT 2020

foad added a comment.

In D87757#2276571 <https://reviews.llvm.org/D87757#2276571>, @arsenm wrote:

> I'm assuming this doesn't fix the problem of spilling unnecessary lanes?

I'm not familiar with that problem but I doubt it. Though it does seem to have slightly reduced the amount of space that `@test_limited_sgpr` uses for spilling.

================
Comment at: llvm/test/CodeGen/AMDGPU/splitkit-copy-live-lanes.mir:5
+# CHECK-LABEL: {{^}}zextload_global_v64i16_to_v64i64:
+name: zextload_global_v64i16_to_v64i64
+tracksRegLiveness: true
----------------
arsenm wrote:
> Missing checks
I only want to check that verification doesn't fail. I was tempted to leave out the `| FileCheck %s` altogether but I recall that some reviewers don't like that. What would you like me to check for?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87757/new/

https://reviews.llvm.org/D87757