[PATCH] D87751: [RDA] Fix getUniqueReachingDef for self loops

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Cheers, LGTM



================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:442
 
-  // If we have a local def and an incoming instruction, then there's not a
-  // unique instruction def.
-  if (!Incoming.empty() && LocalDef)
-    return nullptr;
-  else if (Incoming.size() == 1)
+  // Check that with have a single incoming value and that is does not
+  // come from the same block as MI - since it would mean that the def
----------------
typos: "with" and "that is does"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87751/new/

https://reviews.llvm.org/D87751