[PATCH] D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 03:12:33 PDT 2020


steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13979
   // Floating point types smaller than 32 bits are not legal on Power.
-  if (ResVT.getScalarSizeInBits() < 32)
+  // 128-bit floating point type isn't supported on pre-Power9 subtargets.
+  if (ResVT.getScalarSizeInBits() < 32 ||
----------------
Can we check this with isTypeLegal() instead of enum all the conditions ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86686/new/

https://reviews.llvm.org/D86686



More information about the llvm-commits mailing list