[PATCH] D87751: [RDA] Fix getUniqueReachingDef for self loops

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 03:06:54 PDT 2020


samtebbs added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:451
+    // but that doesn't mean it's the only possible value.
+    return Def->getParent() != MI->getParent() ? Def : nullptr;
+  }
----------------
Small nit but you could use `Parent` here to avoid calling `MI->getParent()` again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87751/new/

https://reviews.llvm.org/D87751



More information about the llvm-commits mailing list