[PATCH] D87326: [ADT] Fix reference invalidation when self referencing a SmallVector
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 16 01:26:19 PDT 2020
xbolva00 requested changes to this revision.
xbolva00 added a comment.
This revision now requires changes to proceed.
>> Tested the newest version of this patch and I'm still seeing massive regressions, even larger than before.
^.
People are hard working to improve compile times and patch like this can just kill their improvements.
I dont think we this is worth it. You can try to create SmallVectorXYZ to handle this case and be strict for SmallVector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87326/new/
https://reviews.llvm.org/D87326
More information about the llvm-commits
mailing list