[PATCH] D87641: [DebugInfo] Add assert for variable size when creating fragments.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D87641#2275598 <https://reviews.llvm.org/D87641#2275598>, @aprantl wrote:

> I'm expecting this to cause all sorts of non-clang frontends to trigger this assertion, since we don't require types to have sizes. In fact, I have an open bug for the Swift frontend to try removing the static sizes from types, since LLDB prefers the dynamic runtime size anyway. 
> If we want to make this a requirement, we should probably implement it as a verifier check instead of an assertion. But I'm not sure if we want to require this for all frontends.

An alternative question then: Should this constraint exist? Or should it be valid to create a fragment that is the same size as the object? (we currently assert in the verifier if the size is available and the fragment covers the whole size: `AssertDI(FragSize != *VarSize, "fragment covers entire variable", Desc, &V);`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87641/new/

https://reviews.llvm.org/D87641