[PATCH] D87623: [CGSCC][NewPM] Fix adding mutually recursive new functions

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 17:31:57 PDT 2020


asbirlea added a comment.

I'd like to revisit this and open a discussion. The `createNode` is only called in `addNewFunctionIntoSCC` and `addNewFunctionIntoRefSCC`, where the former is only called in unit tests and the latter is only used by co-routines. I'm trying to understand what the expected changes in the CallGraph are for some of these methods, if this is specific to coroutines or there are other usecases and if we can get better testing.
Is `registerOutlinedFunction` used out-of tree?

@jdoerfert, @modocache: Could you help me with some context please? (I'm happy to use llvm-dev@ for the discussion too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87623/new/

https://reviews.llvm.org/D87623



More information about the llvm-commits mailing list