[PATCH] D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC.

[Peter Klausler via Phabricator via llvm-commits]

klausler added a comment.

In D87728#2275525 <https://reviews.llvm.org/D87728#2275525>, @Meinersbur wrote:

> The function should be inlined, in which case there is no performance difference.

Sure, but have you measured the performance and verified that there's no penalty in gcc & clang builds for this MSVC work-around?  I'm worried that we'll get to the end of this MSVC bug work-around process, notice that the Linux builds of f18 have lost performance, and somebody else is going to have to figure out which of these patches needs to be reworked to avoid the penalty.  Are you able to measure f18 parsing performance?  If not, let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87728/new/

https://reviews.llvm.org/D87728