[PATCH] D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:596
+  // Remove the old instruction.
+  OldCall->eraseFromParent();
+  Region.Call = Call;
----------------
AndrewLitteken wrote:
> jroelofs wrote:
> > I'd expect an RAUW... what if the call returns something?
> The constructed functions do not return anything based on the CodeExtractor as they only contain single blocks.  Additionally, this function only exists once since the extraction of a region only results in one function.
> 
> After extraction we replace the different calls with a call to the aggregate function we created.
Oh, I see. This is only acting on synthesized calls, not pre-existing ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87294/new/

https://reviews.llvm.org/D87294