[PATCH] D87623: [CGSCC][NewPM] Fix adding mutually recursive new functions

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 13:31:16 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/LazyCallGraph.cpp:1599
-  assert(!lookup(F) && "node already exists");
-
   Node &N = get(F);
----------------
If lookup succeeds, should we just return the result or does it make sense to re-populate etc? We could call this getOrCreateNode?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87623/new/

https://reviews.llvm.org/D87623



More information about the llvm-commits mailing list