[PATCH] D86968: [IRSim] Adding IR Instruction Mapper

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:118
+  /// Instruction performs the same operation.
+  IRInstructionData(Instruction &I, bool Legality);
+
----------------
plotfi wrote:
> Can `Instruction &I` be `const Instruction &I` ?
Not really.  While that would generally work for IRSimilarity, for tools that want to optimize based on the information, the const-ness would become a bit of a restriction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86968/new/

https://reviews.llvm.org/D86968