[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 15 12:33:22 PDT 2020
jroelofs added a comment.
I know almost nothing about how DebugInfo is represented in llvm/dwarf, but is there not a way to represent what this transformation is doing in DI? It's always a little sad when you have to drop it, since doing so makes the debug experience worse.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:314
+ DISubprogram *OutlinedSP = DB.createFunction(
+ Unit /* Context */, F->getName(), StringRef(MangledNameStream.str()),
+ Unit /* File */,
----------------
is the `StringRef()` ctor call necessary?
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:356
+
+ if (MoveDebug)
+ continue;
----------------
where does `moveFunctionData` get called with `MoveDebug` set the other way?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87302/new/
https://reviews.llvm.org/D87302
More information about the llvm-commits
mailing list