[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit for TempFile

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

> The situation where a temp file won't be delete without the delete-on-close bit set seems rare so just avoid setting it entirely.

In my experience, it's actually very common for LLVM tools to leak temp files, so we really need to preserve this functionality, it can't just be removed.

We could accept a more targeted fix. Does the call to CreateFile fail with the delete on close disposition? If so, we could retry without the disposition if it fails.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803