[PATCH] D87468: [Support] Add GlobPattern::isTrivialMatchAll()

[Andrew Ng via Phabricator via llvm-commits]

andrewng marked an inline comment as done.
andrewng added inline comments.


================
Comment at: llvm/unittests/Support/GlobPatternTest.cpp:143
+  const char *NegativeCases[] = {"a*", "*a", "?*", "*?", "**", "\\*"};
+  for (unsigned i = 0; i < array_lengthof(NegativeCases); ++i) {
+    Expected<GlobPattern> Pat2 = GlobPattern::create(NegativeCases[i]);
----------------
MaskRay wrote:
> You can use a range-based for here.
Thanks for spotting that one!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87468/new/

https://reviews.llvm.org/D87468