[PATCH] D86968: [IRSim] Adding IR Instruction Mapper

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 10:51:20 PDT 2020


plotfi added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:120
+  // Make sure we don't overflow or use any integers reserved by the DenseMap.
+  if (LegalInstrNumber >= IllegalInstrNumber)
+    report_fatal_error("Instruction mapping overflow!");
----------------
Can you use llvm's error handling features for this by chance? Could this make sense here?

https://llvm.org/docs/ProgrammersManual.html#error-handling


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86968/new/

https://reviews.llvm.org/D86968



More information about the llvm-commits mailing list