[PATCH] D87674: [AMDGPU] Insert waitcnt after returning from call

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added a comment.





================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:885
+      (MI.isReturn() && MI.isCall() && !callWaitsOnFunctionEntry())) {
+    if (callWaitsOnFunctionReturn(MI))
+      Wait = Wait.combined(AMDGPU::Waitcnt::allZero(ST->hasVscnt()));
----------------
Flakebi wrote:
> madhur13490 wrote:
> > please fuse these two "if" conditions. They are already unreadable.
> Fusing these conditions would change the behavior as the else is executed (and insert waitcnts), so I can’t :)
Ah! I didn't notice the else part. I think the conditions in first "if" (and also of "else if") can be wrapped inside a function for better readability but I'd leave it to you if you want to clean this up :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87674/new/

https://reviews.llvm.org/D87674