[PATCH] D87468: [Support] Add GlobPattern::isTrivialMatchAll()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 09:51:44 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/unittests/Support/GlobPatternTest.cpp:143
+  const char *NegativeCases[] = {"a*", "*a", "?*", "*?", "**", "\\*"};
+  for (unsigned i = 0; i < array_lengthof(NegativeCases); ++i) {
+    Expected<GlobPattern> Pat2 = GlobPattern::create(NegativeCases[i]);
----------------
You can use a range-based for here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87468/new/

https://reviews.llvm.org/D87468



More information about the llvm-commits mailing list