[PATCH] D87695: [Statepoints][ISEL] gc.relocate uniquification should be based on SDValue, not IR Value.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

However, I think this a workaround (and a useful optimization) not a true fix.  What would happen if for some reason a COPY didn't get eliminated?  (Imagine no duplicates, just a single pointer being relocated, with relocated value used down the exceptional path)  I don't have a test case for this, but I'd advise digging into that possibility further.  I'd need to study invoke lowering more closely to understand the risk.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87695/new/

https://reviews.llvm.org/D87695