[PATCH] D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers
Adrian McCarthy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 15 08:48:37 PDT 2020
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
I never realized rc.exe would accept having too few values for a FILEVERSION or PRODUCTVERSION. The documentation implies that you must provide four components--it is the _fixed_ portion of the VERSIONINFO after all. Not that it matters; this looks harmless.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87570/new/
https://reviews.llvm.org/D87570
More information about the llvm-commits
mailing list