[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager
Whitney Tsang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 15 06:45:21 PDT 2020
Whitney added a comment.
In D87045#2265645 <https://reviews.llvm.org/D87045#2265645>, @TaWeiTu wrote:
> In D87045#2264236 <https://reviews.llvm.org/D87045#2264236>, @ychen wrote:
>
>> - How about using `PreservedAnalyses run(Loop &, LoopAnalysisManager &, LoopStandardAnalysisResults &, LPMUpdater &, LoopNest &);` for the interface. I think it should work better because it is still a loop pass interface.
>
> Sounds like a good idea to me. Let' see what @Whitney and @etiotto think about the new interface first, and I'll update the patch later if they agree on that. Thanks!
I am not strongly against it, however is not clear to me what the extra argument `Loop &` provide, as we can get the loop from `LoopNest &` by `LN.getOutermostLoop()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87045/new/
https://reviews.llvm.org/D87045
More information about the llvm-commits
mailing list