[PATCH] D87663: [lld][WebAssembly] Fix --export-all when __stack_pointer is present

Tue Sep 15 06:19:07 PDT 2020

sbc100 added inline comments.

================
Comment at: lld/test/wasm/mutable-globals.s:2
 # RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
-# RUN: not wasm-ld %t.o -o %t.wasm 2>&1 | FileCheck %s
+# RUN: not wasm-ld --allow-undefined %t.o -o %t.wasm 2>&1 | FileCheck %s

----------------
sbc100 wrote:
> tlively wrote:
> > Why was this change necessary?
> Because I moved the calculation of the features section later on the link process, the error regarding `foo` being undefined now get generated before the error we are checking for here `mutable global imported but 'mutable-globals' feature not present in inputs`.
> 
> Does this seems like a reasonable change?
Landing https://reviews.llvm.org/D87666 first made this unnecessary so I could revert it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87663/new/

https://reviews.llvm.org/D87663