[PATCH] D87679: [LV] Unroll factor is expected to be > 0

[Evgeniy via Phabricator via llvm-commits]

ebrevnov marked 4 inline comments as done.
ebrevnov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5617
   // that the target and trip count allows.
   if (IC > MaxInterleaveCount)
     IC = MaxInterleaveCount;
----------------
fhahn wrote:
> IIUC the problem here is in cases when `MaxInterleaveCount == 0`, right? 
> 
> The code below expects MaxInterleaveCount > 0 and I think it would be slightly preferable to make sure `MaxInterleaveCount` is at least 1. With that, the code setting `IC` should do the right thing, and other (potential future) users of `MaxInterleaveCount` can expect a sane value.
> IIUC the problem here is in cases when `MaxInterleaveCount == 0`, right? 
That's right.

> 
> The code below expects MaxInterleaveCount > 0 and I think it would be slightly preferable to make sure `MaxInterleaveCount` is at least 1.
I don't see any uses of MaxInterleaveCount  bellow this point.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87679/new/

https://reviews.llvm.org/D87679