[PATCH] D87667: [Support/Path] Add path::is_gnu_style_absolute
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 15 03:35:35 PDT 2020
rengolin added inline comments.
================
Comment at: llvm/lib/Support/Path.cpp:704
+ // Handle drive letter pattern (i.e "c:") on Windows.
+ if (P.size() >= 2 && (P[0] && P[1] == ':'))
+ return true;
----------------
Neither `7:` nor `$:` are valid paths on Windows, I think.
Perhaps `std::isalpha(P[0])` would help.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87667/new/
https://reviews.llvm.org/D87667
More information about the llvm-commits
mailing list