[PATCH] D87132: [Partial Inliner] Compute intrinsic cost through TTI

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for fixing this issue!



================
Comment at: llvm/test/Transforms/PartialInlining/intrinsic-call-cost.ll:3
+
+;   assert(OutlinedFunctionCost >= Cloner.OutlinedRegionCost &&
+;         "Outlined function cost should be no less than the outlined region");
----------------
Not sure if it is a good idea to include the assertion here, as it may change in the code. It might be better to just explain what the test does, e.g. something like `Check that valid costs are computed for intrinsic calls.`.


================
Comment at: llvm/test/Transforms/PartialInlining/intrinsic-call-cost.ll:6
+
+; RUN: opt -partial-inliner -S < %s | FileCheck %s
+
----------------
Could you move this to the top?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87132/new/

https://reviews.llvm.org/D87132