[PATCH] D87306: [AttributeFuncs] Consider `noundef` in `typeIncompatible`

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 01:25:12 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/DeadArgElim/returned.ll:48
 ; CHECK-LABEL: define internal void @test6
-define internal align 8 dereferenceable_or_null(2) noalias i8* @test6() {
+define internal align 8 dereferenceable_or_null(2) noundef noalias i8* @test6() {
   ret i8* null
----------------
jdoerfert wrote:
> fhahn wrote:
> > could you also add a test where `noundef` needs to be dropped? Here it seems like it is added.
> Here it is dropped. I add it in the input and the output doesn't have any attributes (it's void)
Oh right, didn't look closely enough. The function gets turned into one that returns `void`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87306/new/

https://reviews.llvm.org/D87306



More information about the llvm-commits mailing list