[PATCH] D87663: [lld][WebAssembly] Fix --export-all when __stack_pointer is present
Thomas Lively via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 20:40:19 PDT 2020
tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.
Looks good!
================
Comment at: lld/test/wasm/mutable-globals.s:2
# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
-# RUN: not wasm-ld %t.o -o %t.wasm 2>&1 | FileCheck %s
+# RUN: not wasm-ld --allow-undefined %t.o -o %t.wasm 2>&1 | FileCheck %s
----------------
Why was this change necessary?
================
Comment at: lld/wasm/Writer.cpp:1117-1118
populateSymtab();
+ log("-- populateTargetFeatures");
+ populateTargetFeatures();
log("-- addSections");
----------------
I'm nervous that some of the intervening steps might have depended on the features having been parsed for some reason, but if there was no test breakage, there's probably no issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87663/new/
https://reviews.llvm.org/D87663
More information about the llvm-commits
mailing list