[PATCH] D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes

Mon Sep 14 20:10:30 PDT 2020

ChuanqiXu added a comment.

In D87596#2272955 <https://reviews.llvm.org/D87596#2272955>, @lxfind wrote:

> In D87596#2272950 <https://reviews.llvm.org/D87596#2272950>, @ChuanqiXu wrote:
>
>> In D87596#2271942 <https://reviews.llvm.org/D87596#2271942>, @lxfind wrote:
>>
>>> Thank you for working on this optimization!
>>>
>>> This type of optimizations is typically not enabled in O0, and we probably don't want to either. Should we gate it under the optimization level?
>>
>> This optimization depends on lifetime markers, which would not be produced in O0. So this optimization won't be enabled in O0.
>
> That's not entirely true though. lifetime markers could be enabled with ASAN in O0 for instance.

Oh, I don't recognize there are other cases. I would like to refactor this optimization into a local analyzer pass.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87596/new/

https://reviews.llvm.org/D87596