[PATCH] D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 20:04:18 PDT 2020


lxfind added a comment.

In D87596#2272950 <https://reviews.llvm.org/D87596#2272950>, @ChuanqiXu wrote:

> In D87596#2271942 <https://reviews.llvm.org/D87596#2271942>, @lxfind wrote:
>
>> Thank you for working on this optimization!
>>
>> This type of optimizations is typically not enabled in O0, and we probably don't want to either. Should we gate it under the optimization level?
>
> This optimization depends on lifetime markers, which would not be produced in O0. So this optimization won't be enabled in O0.

That's not entirely true though. lifetime markers could be enabled with ASAN in O0 for instance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87596/new/

https://reviews.llvm.org/D87596



More information about the llvm-commits mailing list