[PATCH] D87538: [VectorCombine] Don't vectorize scalar load under asan/hwasan/memtag/tsan
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 16:36:30 PDT 2020
MaskRay added a comment.
In D87538#2272578 <https://reviews.llvm.org/D87538#2272578>, @vitalybuka wrote:
> If I understand @eugenis comment, for memtag it's better to allow loads inside of 16byte granules.
> But I guess patch as-is is already improvement and 16byte fix can be a followup optimization.
Thanks! Yeah, memtag performance improvement can be done as a follow-up. The `isUnordered()` condition in `mustSuppressSpeculation` may need some thoughts (I left a comment in D66688 <https://reviews.llvm.org/D66688>)
I'd like an approval from @spatel or @RKSimon
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87538/new/
https://reviews.llvm.org/D87538
More information about the llvm-commits
mailing list