[PATCH] D87551: [LICM] Make Loop ICM profile aware again
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 14:24:57 PDT 2020
asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.
Thank you for the patch!
Could you include in the description the benefits seen from adding this, as a data point?
================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:127
/// iteration. Takes DomTreeNode, AAResults, LoopInfo, DominatorTree,
/// TargetLibraryInfo, Loop, AliasSet information for all
+/// BlockFrequencyInfo, TargetLibraryInfo, Loop, AliasSet information for all
----------------
Nit: update comment to include arguments and not duplicate "information for all".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87551/new/
https://reviews.llvm.org/D87551
More information about the llvm-commits
mailing list