[PATCH] D86074: [ARM][MVE] Tail-predication: check get.active.lane.mask's TC value
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 13:59:00 PDT 2020
efriedma added inline comments.
================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:376
- // 1) TODO: Check that the TripCount (TC) belongs to this loop (originally).
+ // 1) Check that the original scalar loop TripCount (TC) belongs to this loop.
// The scalar tripcount corresponds the number of elements processed by the
----------------
Why do we need this check? Emitting vctp32 should be okay even if we can't actually tail-predicate the loop. The overflow check should be enough to ensure that's it's safe to emit vctp32, I think? Or am I forgetting somthing?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86074/new/
https://reviews.llvm.org/D86074
More information about the llvm-commits
mailing list