[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

Mon Sep 14 13:27:44 PDT 2020

dmajor added a comment.

In D87163#2270871 <https://reviews.llvm.org/D87163#2270871>, @fhahn wrote:

> In D87163#2270444 <https://reviews.llvm.org/D87163#2270444>, @thakis wrote:
>
>> Heads-up: We're seeing fairly widespread test failures with this in Chromium that go away when we force this flag off. It's possible that it's due to only a small number of issues and they might be previously-benign UB (no idea), but I figured I'd give an early note. We'll send an update once we've reduced a failing test.
>
> Thanks for the heads-up. I just pushed another fix for the issue @uabelho. I'd guess at least some of the failures you are seeing should be related. If not, I think it makes sense to revert this once we have the reproducers and can work in ironing out the remaining issues.

We're also seeing test failures in Firefox that are not fixed by f715d81c9df3 <https://reviews.llvm.org/rGf715d81c9df3fb3e047a54899fc749f57c84aeb5>. I'll attempt to reduce but it may take some time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87163/new/

https://reviews.llvm.org/D87163