[PATCH] D87310: [IRSim] Adding support for isomorphic predicates

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:134-135
+  /// Get the predicate that the compare instruction is using for hashing the
+  /// instruction. It will throw an error if it used on a IRInstructionData
+  /// not wrapping a CmpInst.
+  CmpInst::Predicate getPredicate() const;
----------------
Since we generally don't build with exceptions turned on, it makes more sense to talk about what's allowed/not in the function's contract, rather than mentioning that assertion failures "throw".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87310/new/

https://reviews.llvm.org/D87310