[PATCH] D87620: [TSAN] Handle musttail call properly in EscapeEnumerator (and TSAN)

[Xun Li via Phabricator via llvm-commits]

lxfind added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/EscapeEnumerator.cpp:111
     CallInst *CI = cast<CallInst>(Calls[--I]);
     changeToInvokeAndSplitBasicBlock(CI, CleanupBB);
   }
----------------
wenlei wrote:
> Does TSAN rely on exit cleanup instrumentation for correctness? How does it work for existing Invoke?
> 
> This patch would be fine if missing some exit instrumentation is ok in general..
The change would just make the call to tsan exit function happen earlier, before the tail call. So we are not missing any exit instrumentation after this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87620/new/

https://reviews.llvm.org/D87620