[PATCH] D87554: [GISel]: Add combine for G_FABS to G_FABS

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 10:24:04 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1826
+  Register AbsSrc;
+  return mi_match(Src, MRI, m_GFabs(m_Reg(AbsSrc)));
+}
----------------
paquette wrote:
> Maybe simpler?
> 
> ```
> return mi_match(MI.getOperand(1).getReg(), MRI, m_GFabs(m_reg(Src)));
> ```
oh wait no that won't work, that'll give the source of the other G_FABS nevermind


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87554/new/

https://reviews.llvm.org/D87554



More information about the llvm-commits mailing list