[PATCH] D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off.
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 14 10:11:10 PDT 2020
AndrewLitteken added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1544
+bool IROutliner::run(Module &M) {
+ CostModel = !NoCostModel;
+
----------------
jroelofs wrote:
> What's the benefit from having this member variable as opposed to just reading the option directly where needed?
It seems like something that might need to be referenced in either the interface file at some point, or somewhere that is not the main file. Since the command line option is static, it can't be accessed if it's not in the class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87299/new/
https://reviews.llvm.org/D87299
More information about the llvm-commits
mailing list