[PATCH] D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:784
+    if (locAsInt % 4 == 0) {
+      write32(loc, 0x60000000);     // NOP
+      write32(loc + 4, 0x38631000); // addi r3, r3, 4096
----------------
Use the constant `NOP`


================
Comment at: lld/ELF/Arch/PPC64.cpp:789
+    else
+      error("R_PPC64_TLSLD has unexpected byte alignment");
     break;
----------------
This can be errorOrWarn as well

We sometimes use `error/fatal` when we want to exit prematurely because some constraints makes it difficult not to do so. For recoverable errors, use errorOrWarn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87504/new/

https://reviews.llvm.org/D87504