[PATCH] D86955: [Hexagon] Make HexagonVLCR compatibile with New PM

Mon Sep 14 09:01:22 PDT 2020

quic_aankit added a comment.

In D86955#2261551 <https://reviews.llvm.org/D86955#2261551>, @pzheng wrote:

> In D86955#2261510 <https://reviews.llvm.org/D86955#2261510>, @quic_aankit wrote:
>
>> In D86955#2261498 <https://reviews.llvm.org/D86955#2261498>, @pzheng wrote:
>>
>>> Is there any existing test case for this pass with the legacy pass manager? If so, you might want to add one with the new pass manager too.
>>
>> All the existing testcases use opt to run the pass. The pass is not run integrated in the main list of passes for any -Ox level.
>
> That's what I meant. For each legacy pass manager test "RUN: opt -hexagon-vlcr ...", you can add a corresponding new pass manager test "RUN: opt -passes=hexagon-vlcr". This way, we will have the same test coverage with both the legacy and new pass managers.

Hi pzheng, I could not figure out a way to register a target specific pass in opt? I can see that llvm/lib/Passes/PassRegistry.def is the registry for target independent passes. Can you point me to an example/API which can help me in registering this pass so that I can use it -passes option in opt?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86955/new/

https://reviews.llvm.org/D86955